test: dependency-relock-only CI bisection (do not merge) - #1146
Draft
RishabhS7 wants to merge 2 commits into
Draft
test: dependency-relock-only CI bisection (do not merge)#1146RishabhS7 wants to merge 2 commits into
RishabhS7 wants to merge 2 commits into
Conversation
… app code changes, to isolate whether the synpress e2e hang is caused by the dependency relock or the app code
❌ Deploy Preview for tradetrust-dev failed. Why did it fail? →
|
❌ Deploy Preview for reference-implementation failed. Why did it fail? →
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@synthetixio/synpress@3.7.3 (unmaintained, unchanged) declares a loose ^1.37.0 range for playwright. Master's lockfile resolved that to 1.42.1; this branch's relock (done much later) floated the same loose range to 1.62.0 - a 20-minor-version jump within the same package that's never been tested against this frozen synpress release. Pinning back to master's exact version to test whether this is the actual cause of the synpress e2e before-all-hook hang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master app code + test files, unchanged, with only package.json/package-lock.json swapped to feat/gasless-transactions dependency versions. Purpose: isolate whether the synpress e2e before-all-hook hang (PR #1144) is caused by the dependency relock or by the actual gasless app code changes. Not intended to be merged.