Skip to content

Add accent-insensitive search module - #30

Open
eDuSHMix wants to merge 1 commit into
Tratosca:mainfrom
eDuSHMix:search-latin
Open

Add accent-insensitive search module#30
eDuSHMix wants to merge 1 commit into
Tratosca:mainfrom
eDuSHMix:search-latin

Conversation

@eDuSHMix

Copy link
Copy Markdown

Summary

Adds an XDJ-RX3 firmware 1.19 module that makes SEARCH insensitive to common Latin accents.

Examples:

  • NINO finds NIÑO
  • CANCION finds CANCIÓN
  • CORAZON finds CORAZÓN
  • MUSICA finds MÚSICA
  • PINGUINO finds PINGÜINO

Displayed track metadata is unchanged. The normalization only affects the SEARCH comparison path.

Technical details

  • Target: XDJ-RX3 firmware 1.19
  • Stock rbp SHA1: cf309238491e73cdbdc1f08a09f7a3177e079068
  • Search normalization routine: shape() at 0x001644FC
  • The stock routine uppercases ASCII a-z
  • This patch extends that normalization for common accented Latin characters and Ñ
  • Implemented using guarded register_patch entries
  • No persistent firmware/storage modification

Validation

Tested on real XDJ-RX3 hardware running firmware 1.19.

Confirmed:

  • NINO -> NIÑO
  • CANCION -> CANCIÓN
  • CORAZON -> CORAZÓN
  • MUSICA -> MÚSICA
  • PINGUINO -> PINGÜINO
  • Normal ASCII searches continue to work
  • rbp restarts successfully
  • Power cycling without the mod restores stock behavior

Local validation:

  • make hook
  • make test
  • make preflight

All completed successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant