Skip to content

[WIP] Add logic to improve write/read access determination#32

Closed
TrudAX with Copilot wants to merge 1 commit into
masterfrom
copilot/improve-access-logic
Closed

[WIP] Add logic to improve write/read access determination#32
TrudAX with Copilot wants to merge 1 commit into
masterfrom
copilot/improve-access-logic

Conversation

Copilot AI commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Create an issue in TrudAX/XppTools to Current logic for defining Write or Read access based on the following parameters (https://denistrunin.com/xpptools-licenseusagelog/#calculating-data-modifications )

  • Table ModifiedBy and CreatedBy fields - This is not always fully reliable, as it only records the last user who touched the record.
  • SysDatabaseLog table - This provides more accurate event information, but it must be enabled in advance.
    This has an obvious limitation; it may not be accurate on the individual form level.

The proposal is to improve it by the following modification (proposed by Nikolaj Sørensen):

What about subscribing to the ApplicationBase.onFormOpened
Then we can loop over the datasouces and subscribe to the write events?
Thinking about structuring along the lines of:

Subsribe to: ApplicationBase.onFormOpened


Class: DEVLicenseWriteLogHandler.ApplicationBase_onFormOpened()
│ loops over all datasources on the opened form
│ attaches onInserted / onUpdated / onDeleted to each


Class: DEVLicenseWriteMonitor.onDsInserted/Updated/Deleted()
│ called after a confirmed database write
│ reads formRun.args().menuItemName() for exact menu item

Table: DevLicenseWriteLog

Some notes from me:
It should be a configurable modification, the main development principle: avoid any errors if possible. The logging event should be one per table, so it should not overload the system.
The current structure supports different channels, so this mod should fit the current code.
In theory, it should give more accurate reporting that will be tailored to a form


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI requested a review from TrudAX March 13, 2026 10:02
Copilot stopped work on behalf of TrudAX due to an error March 13, 2026 10:02
@TrudAX TrudAX closed this Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants