Conversation
#97) * feat: replace Partners tab with Verticals dropdown and remove partners page - Navbar Partners tab is now a Verticals dropdown (desktop + mobile) linking to TradeTrust, OpenCerts, and SAL, opening in new tabs - Remove /partners route and PartnersSection from Home - Pin @trustvc/trustvc to 2.15.0-beta.2 in lockfile Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test: update navbar and home tests for Verticals dropdown - Navbar/App tests: expect Verticals instead of removed Partners tab - Add Verticals dropdown test asserting TradeTrust/OpenCerts/SAL links - Drop Home Partners-section tests (section removed) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: keep mobile Verticals submenu interactions contained on outside-click The document mousedown handler closed the Verticals dropdown whenever the target was outside the desktop dropdown container, so taps on the mobile submenu (links and toggle) unmounted the target before click fired. Track the mobile menu with its own ref and treat clicks inside either container as contained. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughThe navbar replaces the Partners link with responsive Verticals dropdowns for TradeTrust, OpenCerts, and SAL. The Partners route and home-page section are removed. Tests cover desktop and mobile menu behavior. ChangesVerticals navigation replacement
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/common/Navbar/Navbar.test.tsx`:
- Around line 49-51: Update the desktop Verticals trigger lookup in the Navbar
test to query within the desktop navigation container rather than using the
global screen query. Reuse the existing container-scoping pattern and keep the
role/name matcher unchanged so the desktop control is selected uniquely.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a081d372-8036-45f1-b3b4-daac10e11d47
📒 Files selected for processing (6)
src/App.test.tsxsrc/__tests__/home.test.tsxsrc/components/common/Navbar/Navbar.test.tsxsrc/components/common/Navbar/Navbar.tsxsrc/pages/Home/index.tsxsrc/routes.tsx
💤 Files with no reviewable changes (3)
- src/routes.tsx
- src/tests/home.test.tsx
- src/pages/Home/index.tsx
Comment on lines
+49
to
+51
| fireEvent.click( | ||
| screen.getByRole('button', { name: /toggle verticals menu/i }) | ||
| ) |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Scope the desktop Verticals trigger query.
Navbar renders both Verticals triggers in the test DOM. screen.getByRole() can find two controls named "Toggle verticals menu" and throw. Scope this query to the desktop navigation container, as the mobile test does for its trigger.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/common/Navbar/Navbar.test.tsx` around lines 49 - 51, Update
the desktop Verticals trigger lookup in the Navbar test to query within the
desktop navigation container rather than using the global screen query. Reuse
the existing container-scoping pattern and keep the role/name matcher unchanged
so the desktop control is selected uniquely.
rongquan1
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…… (#97)
The document mousedown handler closed the Verticals dropdown whenever the target was outside the desktop dropdown container, so taps on the mobile submenu (links and toggle) unmounted the target before click fired. Track the mobile menu with its own ref and treat clicks inside either container as contained.
Summary by CodeRabbit
New Features
Changes
/partnerspage route.