Fix #2568: move settings section titles to header#3193
Open
franciscommmarques wants to merge 3 commits into
Open
Fix #2568: move settings section titles to header#3193franciscommmarques wants to merge 3 commits into
franciscommmarques wants to merge 3 commits into
Conversation
Settings section titles were previously rendered inside the scrollable content area, causing them to scroll out of view and breaking the intended visual hierarchy. This change ensures that section titles are rendered in the settings header alongside the navigation controls, preserving visibility and layout consistency across all settings tabs. A regression test was added to verify that tab titles are rendered in the header area and do not appear inside the scrollable content region, preventing future regressions.
franciscommmarques
force-pushed
the
fix/settings-titles-header-clean-develop
branch
from
cccdd3a to
ab5ec32
Compare
Author
|
Hi @holmesworcester, Just wanted to follow up on this PR. I've updated it and resolved the merge conflicts. Is there anything I can improve or any feedback you can share? Happy to make any changes needed. Thanks! |
Author
|
Hi @holmesworcester, Just checking in again on this PR. Let me know if there's anything you'd like me to change. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings section titles were previously rendered inside the scrollable content area, causing them to scroll out of view and breaking the intended visual hierarchy.
This change ensures that section titles are rendered in the settings header alongside the navigation controls, preserving visibility and layout consistency across all settings tabs.
A regression test was added to verify that tab titles are rendered in the header area and do not appear inside the scrollable content region, preventing future regressions.
Fix #2568
Pull Request Checklist