Feat #572: add emoji reactions to messages (desktop)#3265
Open
franciscommmarques wants to merge 4 commits into
Open
Feat #572: add emoji reactions to messages (desktop)#3265franciscommmarques wants to merge 4 commits into
franciscommmarques wants to merge 4 commits into
Conversation
Users had no way to react to messages with emojis. This feature was listed in the project backlog and had an associated Figma design file that guided the implementation. Reactions are stored as ChannelMessage entries with a new MessageType.Reaction type, requiring no changes to the backend, OrbitDB layer, or socket events. The state-manager aggregates raw reaction entries into grouped state via a new Redux slice and selector. The desktop UI adds a MessageReactionBar component below each message: - Reaction pills with counters and tooltips showing who reacted - Shown on hover when no reactions exist, always visible otherwise - Quick picker with 6 curated emojis and a button for the full picker - Excess reactions beyond 5 collapsed into a "+N" expandable indicator Unit tests were added to verify that reaction messages are correctly extracted from the incoming message pipeline, that non-reaction messages are not affected, and that the toggle (add/remove) logic works as expected.
Author
|
Hi @holmesworcester, Just wanted to check in on this PR whenever you get a chance to take a look. Let me know if there's anything you'd like me to change. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users had no way to react to messages with emojis. This feature was listed in the project backlog and had an associated Figma design file that guided the implementation.
Reactions are stored as ChannelMessage entries with a new MessageType.Reaction type, requiring no changes to the backend, OrbitDB layer, or socket events. The state-manager aggregates raw reaction entries into grouped state via a new Redux slice and selector.
The desktop UI adds a MessageReactionBar component below each message:
Unit tests were added to verify that reaction messages are correctly extracted from the incoming message pipeline, that non-reaction messages are not affected, and that the toggle (add/remove) logic works as expected.
Closes #572
Pull Request Checklist