[codex] Add channel membership auth PoC#3302
Draft
holmesworcester wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a focused PoC test showing that, once the backend owner check is bypassed, a non-owner private-channel member can add another member to the channel role and have that change accepted after LFA graph merge.
The test also verifies that the newly added member receives usable channel role keys by decrypting a role-scoped message after the merge.
Why
PR #3299 constrains channel-member additions at the backend/UI path, but the underlying LFA
ADD_MEMBER_ROLEvalidation accepts assignments to other users. This test documents that mismatch in shared state.Validation
Ran the focused backend spec under the repo-supported Node runtime:
Result: 11 passed.