Skip to content

Fix plot weather data func#48

Open
chenzhao299 wants to merge 2 commits into
mainfrom
fix-plot_weather_data-func
Open

Fix plot weather data func#48
chenzhao299 wants to merge 2 commits into
mainfrom
fix-plot_weather_data-func

Conversation

@chenzhao299

Copy link
Copy Markdown
Collaborator

Addressed various fixes from Marco and Chad's reviews:

  • Marco:

    • Simplified the repeated codes in plot_weather_data() function
    • Set default parameters for time_basis and col_name argument of plot_weather_data() function
    • Fix single quote mark problem in plot_weather_data() function's docstring
    • Add explaination of how to get the obs_df in plot_weather_data() function's docstring
  • Chad:

    • Delete tests/test_noaastn.py file
    • Written plot_weather_data() function in a more DRY fashion based on the suggestion, thank you for that!
    • Labled x-axis nicely when using the plot_weather_data() function with "daily"argument

@codecov

codecov Bot commented May 2, 2021

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@chenzhao299 chenzhao299 linked an issue May 2, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package Review Suggestion For plot_weather_data

1 participant