add option to disable file logger, change default db log level#9
Draft
sheb-gregor wants to merge 1 commit into
Draft
add option to disable file logger, change default db log level#9sheb-gregor wants to merge 1 commit into
sheb-gregor wants to merge 1 commit into
Conversation
sheb-gregor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make file logging optional
Summary
When RGB-lib is being used as a part of some service, logging directly to a file leads to:
I've added an option to disable this file log.
Also, the log level of database queries produced by SeaORM was changed from INFO to DEBUG.
Logging all DB queries at the INFO level is inappropriate.