Shellcheck tweaks to migrate.sh#151
Closed
givensuman wants to merge 1 commit intoUltramarine-Linux:mainfrom
Closed
Shellcheck tweaks to migrate.sh#151givensuman wants to merge 1 commit intoUltramarine-Linux:mainfrom
givensuman wants to merge 1 commit intoUltramarine-Linux:mainfrom
Conversation
GildedRoach
reviewed
Feb 26, 2026
| echo " ...[2/3] Terra" | ||
| if [ "$(rpm -qa terra-release | head -c1 | wc -c)" -eq 0 ]; then | ||
| trace sudo dnf install -y --repofrompath 'terra,https://repos.fyralabs.com/terra$releasever' --setopt="terra.gpgkey=https://repos.fyralabs.com/terra$releasever/key.asc" terra-release | ||
| trace sudo dnf install -y --repofrompath "terra,https://repos.fyralabs.com/terra$releasever" --setopt="terra.gpgkey=https://repos.fyralabs.com/terra$releasever/key.asc" terra-release |
Collaborator
There was a problem hiding this comment.
This is wrong. The shell would end up expanding this instead of DNF (the latter is necessary). Shellcheck does not have the context for this.
GildedRoach
reviewed
Feb 26, 2026
| echo " ...[3/3] Ultramarine Repositories" | ||
| if [ "$(rpm -qa ultramarine-repos-common | head -c1 | wc -c)" -eq 0 ]; then | ||
| trace sudo dnf install -y --repofrompath 'ultramarine,https://repos.fyralabs.com/um$releasever' --setopt="ultramarine.gpgkey=https://repos.fyralabs.com/um$releasever/key.asc" ultramarine-repos-common | ||
| trace sudo dnf install -y --repofrompath "ultramarine,https://repos.fyralabs.com/um$releasever" --setopt="ultramarine.gpgkey=https://repos.fyralabs.com/um$releasever/key.asc" ultramarine-repos-common |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I was copying your guys'
migrate.shfor my own project and noticed it wasn't passingshellcheck.These are just string splitting warnings, but I also noticed an inconsistency in warning messages formatted with "-->" and "[!]"