Optimize signed variants of getAmount0Delta and getAmount1Delta#677
Closed
shuhuiluo wants to merge 3 commits into
Closed
Optimize signed variants of getAmount0Delta and getAmount1Delta#677shuhuiluo wants to merge 3 commits into
getAmount0Delta and getAmount1Delta#677shuhuiluo wants to merge 3 commits into
Conversation
The code in `SqrtPriceMath` has been refactored to optimize the functions `getAmount0Delta` and `getAmount1Delta`. The changes replaced previous return statements with inline assembly to handle operations on `int256` more efficiently. This has resulted in reduction in bytecode size and runtime gas.
Merged
Contributor
|
Hi! Closing this as we are not going to be merging this change 🙏 we appreciate the time you took making this contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factored out of #258.
Related Issue
Which issue does this pull request resolve?
Description of changes
The code in
SqrtPriceMathhas been refactored to optimize the functionsgetAmount0DeltaandgetAmount1Delta. The changes replaced previous return statements with inline assembly to handle operations onint256more efficiently. This has resulted in reduction in bytecode size and runtime gas.