Spearbit core issues#857
Merged
Merged
Conversation
|
Forge code coverage:
|
dianakocsis
requested changes
Aug 29, 2024
snreynolds
reviewed
Aug 30, 2024
| // avoid implicit upcasting | ||
| _liquidity := and(liquidity, 0xffffffffffffffffffffffffffffffff) | ||
| } | ||
| uint256 _liquidity = uint256(liquidity); |
Contributor
There was a problem hiding this comment.
hm but why do we have a comment that says "avoid implicit upcasting".. feels like this is what we/someone was trying to avoid?
Contributor
Author
There was a problem hiding this comment.
it was just done in PR #676 to save gas. But now that we've added masking and optimiser runs are higher, it doesnt save gas anymore.
dianakocsis
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes for:
https://github.com/spearbit-audits/review-uniswap-v4/issues/58
https://github.com/spearbit-audits/review-uniswap-v4/issues/102
https://github.com/spearbit-audits/review-uniswap-v4/issues/67
https://github.com/spearbit-audits/review-uniswap-v4/issues/95
https://github.com/spearbit-audits/review-uniswap-v4/issues/57