FIX: Update sample materials to be URP/HDRP compatible [TBD]#2223
Open
Pauliusd01 wants to merge 23 commits intodevelopfrom
Open
FIX: Update sample materials to be URP/HDRP compatible [TBD]#2223Pauliusd01 wants to merge 23 commits intodevelopfrom
Pauliusd01 wants to merge 23 commits intodevelopfrom
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2223 +/- ##
===========================================
+ Coverage 68.14% 76.70% +8.55%
===========================================
Files 367 465 +98
Lines 53685 87920 +34235
===========================================
+ Hits 36584 67436 +30852
- Misses 17101 20484 +3383 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 98 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Getting shader errors on build on 6.3 at the moment |
Collaborator
|
Might be that this is still in flight but would recommend updating CHANGELOG to reflect these changes. |
Collaborator
|
@Pauliusd01 Please update this PR with latest develop to get critical CI fix from #2260. I do not dare doing it for you since the branch has conflicts I may not understand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switches out sample materials to a shadergraph one that is cross compatible between URP/HDRP. One caveat is that if someone wants to use it with the old built in render pipeline they have to install the shadergraph package. Also, this adds a dependency to our own main project as it is a built in render pipeline project.
Note: Shadergraph version added is the one offered by 22.3 which seems to update just fine across our supported editors
Testing status & QA
Import changed samples locally through the package manager, run every scene in player and play mode in a new URP & HDRP project. (22.3, 6.0 & trunk)
Overall Product Risks
Comments to reviewers
None yet, TBD
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: