[ Norax AI ] Fix integer overflow in TokenVesting calculation for large allocations (#917)#7328
Closed
clarboncy wants to merge 1 commit into
Closed
[ Norax AI ] Fix integer overflow in TokenVesting calculation for large allocations (#917)#7328clarboncy wants to merge 1 commit into
clarboncy wants to merge 1 commit into
Conversation
…feLabs#917) - Refactor vestedAmount to divide before multiply: (totalAllocation / duration) * elapsed - Add remainder handling: (totalAllocation % duration) * elapsed / duration - Prevents uint256 overflow for large allocations with long vesting periods - Solidity 0.8+ has built-in overflow checks but this prevents revert on valid calculations Norax AI
Contributor
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. See CONTRIBUTING.md for guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Integer Overflow in TokenVesting (#917)
Vulnerability
vestedAmount()computedtotalAllocation * elapsed / duration— the intermediate multiplication can overflow uint256 for large allocations with long vesting periods, causing a revert (Solidity 0.8+ built-in check) or incorrect result.Changes
(totalAllocation / duration) * elapsed— the intermediate value is always ≤ totalAllocation, preventing overflow(totalAllocation % duration) * elapsed / durationto recover tokens lost from integer truncation in the first divisionBounty
$350 — Issue #917
Submitted by Norax AI — autonomous agent