Skip to content

Bump socket.io-parser from 4.0.4 to 4.0.5 in /research-hub-web#364

Open
dependabot[bot] wants to merge 2111 commits intomasterfrom
dependabot/npm_and_yarn/research-hub-web/socket.io-parser-4.0.5
Open

Bump socket.io-parser from 4.0.4 to 4.0.5 in /research-hub-web#364
dependabot[bot] wants to merge 2111 commits intomasterfrom
dependabot/npm_and_yarn/research-hub-web/socket.io-parser-4.0.5

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Nov 29, 2022

Bumps socket.io-parser from 4.0.4 to 4.0.5.

Release notes

Sourced from socket.io-parser's releases.

4.0.5

Bug Fixes

  • check the format of the index of each attachment (b559f05)

Links

Changelog

Sourced from socket.io-parser's changelog.

4.0.5 (2022-06-27)

Bug Fixes

  • check the format of the index of each attachment (b559f05)

4.2.0 (2022-04-17)

Features

  • allow the usage of custom replacer and reviver (#112) (b08bc1a)

4.1.2 (2022-02-17)

Bug Fixes

  • allow objects with a null prototype in binary packets (#114) (7f6b262)

4.1.1 (2021-10-14)

4.1.0 (2021-10-11)

Features

  • provide an ESM build with and without debug (388c616)
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

rosemcc and others added 30 commits November 8, 2021 14:13
Bumps [cypress-commands](https://github.com/Lakitna/cypress-commands) from 1.1.0 to 2.0.1.
- [Release notes](https://github.com/Lakitna/cypress-commands/releases)
- [Changelog](https://github.com/Lakitna/cypress-commands/blob/develop/CHANGELOG.md)
- [Commits](Lakitna/cypress-commands@1.1.0...2.0.1)

---
updated-dependencies:
- dependency-name: cypress-commands
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
* generated new components

* first version of contact card

* changed card title color

* fixed elevation

* first version of org unit card

* first version of document card

* moved cards module and components

* article simplification

* changed mouse pointer on card

* minor change to article page

* Revert "minor change to article page"

This reverts commit 4c66bf8.

* case-studys page refactor

* fixed width cards, minor article change

* changed equipment page

* changes to events

* changed fundings page

* changes to service page

* changes to software page

* changes to subhubs and standard card

* set image height

* removed app-cards from featured component

* removed old cards components

* fixed featured layout

* better spacing on featured component

* fixed lock icon size

* fixed article layout

* fixed mobile card width

* fixed clickable cards

* generated new components

* first version of contact card

* changed card title color

* fixed elevation

* first version of org unit card

* first version of document card

* moved cards module and components

* article simplification

* changed mouse pointer on card

* minor change to article page

* Revert "minor change to article page"

This reverts commit 4c66bf8.

* case-studys page refactor

* fixed width cards, minor article change

* changed equipment page

* changes to events

* changed fundings page

* changes to service page

* changes to software page

* changes to subhubs and standard card

* set image height

* removed app-cards from featured component

* removed old cards components

* fixed featured layout

* better spacing on featured component

* fixed lock icon size

* fixed article layout

* fixed mobile card width

* fixed clickable cards

* generated new components

* first version of contact card

* changed card title color

* fixed elevation

* first version of org unit card

* first version of document card

* moved cards module and components

* article simplification

* changed mouse pointer on card

* minor change to article page

* Revert "minor change to article page"

This reverts commit 4c66bf8.

* case-studys page refactor

* fixed width cards, minor article change

* changed equipment page

* changes to events

* changed fundings page

* changes to service page

* changes to software page

* changes to subhubs and standard card

* set image height

* removed app-cards from featured component

* removed old cards components

* fixed featured layout

* better spacing on featured component

* fixed lock icon size

* fixed article layout

* fixed mobile card width

* fixed clickable cards

* generated new components

* first version of contact card

* changed card title color

* fixed elevation

* first version of org unit card

* first version of document card

* moved cards module and components

* changed mouse pointer on card

* minor change to article page

* Revert "minor change to article page"

This reverts commit 4c66bf8.

* fixed width cards, minor article change

* fixed clickable cards

* minor fixes

* article layout fixes

* fixes for case studies layout

* more layout fixes

* fixed unit tests

* fix for equipment table

* upgraded e2e test with cypress types, fixed e2e tests

* fixed inconsistent bottom margin

* mat-icon white on subhub child card

* added missing case study references

* fixed 3 column layout being too narrow

* fixed you-might-be-interested-in id

* fixed featured layout

* fixed missing funding purpose

* fixed body media error

* fix nulls error on subhub pages

* fixed title underline

* Revert "fixed title underline"

This reverts commit d92ba98.

* fixed subhub child card underline

Co-authored-by: Rose McColl <rosemccoll@hotmail.com>
…search-hub-web/cypress-commands-2.0.1

Bump cypress-commands from 1.1.0 to 2.0.1 in /research-hub-web
rosemcc and others added 18 commits March 21, 2022 12:14
* initial commit for content graph

* added resolver and adjustments, highlight node on hover

* update lockfile version

* minor fixes for null checks

* added auth guard to graph route

* first version of node info box

* added node highlighting

* improved details list and highlighting

* first version of graph legend in drawer

* layout fixes

* layout improvements

* renamed graph-legend to graph-filter

* added legend, added dev env

* added graph link to footer

* fixed capitalisation

* some fixes for unit tests

* more fixes for tests

* exclude GraphFilter test for now

* added graph API to CSP headers (dev)

* renamed graph-container

* refactored graph into component

* tidy up field order

* changed loading behaviour, removed route resolver

* fixed canvas width, colour changes

* fixed color legend and search box

* minor improvements

* many UI improvements, added contentful link to env files

* updated test and prod environment files with graph api url

* some fixes for unit tests

* more fixes for unit tests

* minor improvements for node details UI

* added graph api to csp headers in cloudfront functions

* rebuild package-lock.json

* added esbuild dep
* Add token references for CI build

* Add missing package

* Fix npm shrinkwrap issue

* Fix wrong org id

* Update readme

* Update documentation

* Add indentation and minor fixes to README

* FIx minor heading issue with readme

Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com>
Co-authored-by: rosemcc <rosemccoll@hotmail.com>
Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com>
* chore: version update

* CHORE: update versions

* HOTFIX

* Chore: version changes

Co-authored-by: Rose <31844476+rosemcc@users.noreply.github.com>
Co-authored-by: rosemcc <rosemccoll@hotmail.com>
Co-authored-by: Lukas Trombach <lukas.trombach@auckland.ac.nz>
Co-authored-by: Lukas Trombach <19306765+Trombach@users.noreply.github.com>
Co-authored-by: etan221 <eric.tan@auckland.ac.nz>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 29, 2022
Trombach and others added 4 commits December 1, 2022 17:09
* add initial modules and components

* update search lambda

* update and add new graphQL queries

* add capability type to standard card

* add components to routes

* add capability list

* reuse article default banner for capability card for now

* add capability display name to pipe

* first version of capability page

* make tests runnable

* add capability page type to search types

* add navbar link to subhub

* add capability list unit test

* make e2e tests runnable

* fix unit test

* fix unit tests

* add capability unit test

* decapitalised navbar link

* added new card background for capability

* add capability e2e tests and fixture

* fix capability not showing in search results

* fix e2e test

* add capability type to content graph

* remove navbar link to be added later

* fix standard card default image loading

* lowercase sign in/out

* move support materials to the top

* fix unit test

* fix navbar e2e test

* move contacts to the top

* minor fix for standard images

* simplify standard card component

* add comment explaining image height
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io-parser@4.0.4...4.0.5)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/research-hub-web/socket.io-parser-4.0.5 branch from 2b91932 to d9bebeb Compare December 2, 2022 01:13
@lugn621 lugn621 force-pushed the dependabot/npm_and_yarn/research-hub-web/socket.io-parser-4.0.5 branch from d9bebeb to 0ba1850 Compare April 2, 2026 02:11
Comment on lines +15 to +36
name: Run linters
runs-on: ubuntu-latest

steps:
- name: Check out Git repository
uses: actions/checkout@v2

- name: Set up Node.js
uses: actions/setup-node@v1
with:
node-version: 14

- name: Install Node.js dependencies
working-directory: ./research-hub-web
run: npm ci

- name: Install Angular CLI
run: npm install -g @angular/cli

- name: ng lint
working-directory: ./research-hub-web
run: ng lint

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 9 days ago

To fix this, we should explicitly declare minimal GITHUB_TOKEN permissions for the workflow. Since the job only checks out the repository and runs Node/Angular tooling, it only requires read access to repository contents. The recommended minimal starting point from CodeQL is permissions: { contents: read }.

The best fix without changing existing functionality is to add a permissions block at the workflow root (top level, alongside name: and on:). This will apply to all jobs in this workflow, including run-linters, and restrict the GITHUB_TOKEN to read-only repository contents. No additional scopes (like pull-requests or issues) are needed based on the provided steps.

Concretely:

  • Edit .github/workflows/linting.yml.
  • Insert a new permissions: section after name: Lint (line 1) and before on: (line 3).
  • Set contents: read as the only permission.

No imports, methods, or other definitions are required since this is purely a YAML workflow configuration change.

Suggested changeset 1
.github/workflows/linting.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml
--- a/.github/workflows/linting.yml
+++ b/.github/workflows/linting.yml
@@ -1,4 +1,6 @@
 name: Lint
+permissions:
+  contents: read
 
 on:
   # Trigger the workflow on push or pull request,
EOF
@@ -1,4 +1,6 @@
name: Lint
permissions:
contents: read

on:
# Trigger the workflow on push or pull request,
Copilot is powered by AI and may make mistakes. Always verify output.
Comment on lines +14 to +33
name: Create Sentry Release
runs-on: ubuntu-latest

steps:
- name: Check out Git repository
uses: actions/checkout@v2
- name: Get Branch
id: var
run: echo ::set-output name=branch::${GITHUB_REF#refs/*/}
- name: Output Branch
run: echo ${{ steps.var.outputs.branch }}
- name: Notify Sentry
# https://github.com/getsentry/action-release
uses: getsentry/action-release@v1.1.6
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
SENTRY_ORG: university-of-auckland-7o
SENTRY_PROJECT: research-hub
with:
environment: ${{ steps.var.outputs.branch }} No newline at end of file

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 9 days ago

In general, you fix this by explicitly setting a permissions: block to restrict the default GITHUB_TOKEN for the workflow or for each job. Start with minimal read-only access (e.g., contents: read) and only add additional scopes if the workflow or its actions truly require them.

For this specific workflow, the simplest and safest change without altering existing behavior is to add a workflow-level permissions: block granting read-only access to repository contents. There is no evidence in the snippet that any step needs write permission to the repo, issues, or pull requests. Place the permissions block near the top of the file (after name: and before on:) so it applies to all jobs, including sentry-release. No imports or other definitions are required; this is purely a YAML configuration change in .github/workflows/sentry.yml.

Concretely: in .github/workflows/sentry.yml, insert

permissions:
  contents: read

after line 1 (name: Sentry Release). No other lines need modification.

Suggested changeset 1
.github/workflows/sentry.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/sentry.yml b/.github/workflows/sentry.yml
--- a/.github/workflows/sentry.yml
+++ b/.github/workflows/sentry.yml
@@ -1,5 +1,8 @@
 name: Sentry Release
 
+permissions:
+  contents: read
+
 on:
   push:
     branches:
EOF
@@ -1,5 +1,8 @@
name: Sentry Release

permissions:
contents: read

on:
push:
branches:
Copilot is powered by AI and may make mistakes. Always verify output.
run: echo ${{ steps.var.outputs.branch }}
- name: Notify Sentry
# https://github.com/getsentry/action-release
uses: getsentry/action-release@v1.1.6

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Sentry Release' step
Uses Step
uses 'getsentry/action-release' with ref 'v1.1.6', not a pinned commit hash

module.exports.search = async (event, context) => {
try {
console.log(`Received query: ${event.body}`);

Check warning

Code scanning / CodeQL

Log injection Medium

Log entry depends on a
user-provided value
.

Copilot Autofix

AI 9 days ago

In general, to fix log injection issues, any user-controlled data should be sanitized before being interpolated into log messages. For plain-text logs, this typically means stripping or replacing newline and carriage-return characters and optionally truncating very long input. It is also useful to clearly delimit or quote user input in the log message so it cannot be confused with log syntax.

For this specific file (hub-search-proxy/handler.js), the best fix is to sanitize event.body before logging it. We can do that locally inside the search handler without changing behavior elsewhere. Right before the console.log call, introduce a local variable, e.g. safeBody, which is derived from event.body by converting it to a string and removing \r and \n. Then log that sanitized value instead of event.body. This preserves the information content of the body (minus newlines) for debugging while preventing an attacker from injecting extra log lines. No additional imports are needed; we can rely on built-in String methods and a simple regular expression.

Concretely:

  • In hub-search-proxy/handler.js, within module.exports.search, around line 53:
    • Replace console.log(Received query: ${event.body}); with a two-line sequence:
      • First, define const safeBody = String(event.body).replace(/[\r\n]/g, '');
      • Then, log safeBody instead of event.body.
  • No other regions of the file need modification, since this is the only flagged use.
Suggested changeset 1
hub-search-proxy/handler.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/hub-search-proxy/handler.js b/hub-search-proxy/handler.js
--- a/hub-search-proxy/handler.js
+++ b/hub-search-proxy/handler.js
@@ -50,10 +50,10 @@
 
 module.exports.search = async (event, context) => {
     try {
-        console.log(`Received query: ${event.body}`);
+        const safeBody = String(event.body).replace(/[\r\n]/g, '');
+        console.log(`Received query: ${safeBody}`);
         const requestBody = JSON.parse(event.body);
         let queryString = '';
-        let size = 10;
         let from = 0;
         let queryFilters = {};
         let queryFiltersCount = 0;
EOF
@@ -50,10 +50,10 @@

module.exports.search = async (event, context) => {
try {
console.log(`Received query: ${event.body}`);
const safeBody = String(event.body).replace(/[\r\n]/g, '');
console.log(`Received query: ${safeBody}`);
const requestBody = JSON.parse(event.body);
let queryString = '';
let size = 10;
let from = 0;
let queryFilters = {};
let queryFiltersCount = 0;
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants