fix: destroy Packery instance on unmount to stop memory leak in SponsorBubbles#233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from claude:
Summary
Fixes a memory leak on the home page caused by
SponsorBubblescreating a newPackery layout instance on every mount and on every
baseSizechange withoutever destroying the previous one. Each navigation back to
/left behind afull Packery instance plus all its DOM references, which Chrome's heap profiler
showed as a steadily growing pile of detached nodes and
PackeryItemobjects.Root cause
In
src/app/(frontend)/(home)/_components/SponsorBubbles.tsx, the Packeryeffect was calling
new Packery(...)and discarding the return value:Packery attaches listeners to the container and holds references to every
matched grid item. Without a handle to the instance, there was no way to call
.destroy(), so each remount stacked another live instance on top of the
previous one.
A secondary issue: the scroll-listener effect listed hoveredSponsor in its
dependency array, so the listener was being torn down and re-attached on every
hover change.
Changes
cleanup (runs on unmount and before re-init when baseSize changes).
not construct an orphaned instance after unmount.
hoveredSponsor from the effect deps so the listener attaches once.