Open
Conversation
quarium
force-pushed
the
upipe_interlace
branch
4 times, most recently
from
b3ef35b to
72dfc5c
Compare
nto
requested changes
Feb 2, 2026
quarium
force-pushed
the
upipe_interlace
branch
2 times, most recently
from
a2f0f55 to
62bcc49
Compare
quarium
force-pushed
the
upipe_interlace
branch
2 times, most recently
from
b0524fe to
df085df
Compare
Contributor
|
Some filtering of fields like FFmpeg does would be nice. |
Contributor
Author
|
@kierank is that ok for you? |
Contributor
|
Yes it looks better and we will probably improve the filter one day
…On Wed, 8 Apr 2026, 15:17 Arnaud de Turckheim, ***@***.***> wrote:
*quarium* left a comment (Upipe/upipe#1140)
<#1140 (comment)>
@kierank <https://github.com/kierank> is that ok for you?
—
Reply to this email directly, view it on GitHub
<#1140 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABDEECF242KWAZI62NIOKD4UZNP3AVCNFSM6AAAAACTOMZJJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMBWHEZDKMZSHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
nto
requested changes
Apr 8, 2026
quarium
force-pushed
the
upipe_interlace
branch
3 times, most recently
from
6771397 to
3dce434
Compare
Add upipe_interlace pipe to preform temporal field interlacing.
quarium
force-pushed
the
upipe_interlace
branch
from
3dce434 to
88852f1
Compare
nto
requested changes
Apr 10, 2026
Comment on lines
+154
to
+155
| struct upipe_mgr * | ||
| upipe_interlace_mgr_alloc(void); |
Collaborator
There was a problem hiding this comment.
Suggested change
| struct upipe_mgr * | |
| upipe_interlace_mgr_alloc(void); | |
| struct upipe_mgr *upipe_interlace_mgr_alloc(void); |
| struct upipe upipe; | ||
| }; | ||
|
|
||
| UPIPE_HELPER_UPIPE(upipe_interlace, upipe, UPIPE_INTERLACE_SIGNATURE); |
Collaborator
There was a problem hiding this comment.
Suggested change
| UPIPE_HELPER_UPIPE(upipe_interlace, upipe, UPIPE_INTERLACE_SIGNATURE); | |
| UPIPE_HELPER_UPIPE(upipe_interlace, upipe, UPIPE_INTERLACE_SIGNATURE) |
| upipe_warn_va(upipe, "input interlacing mismatch, got %s need %s", | ||
| input_tff ? "tff" : "bff", | ||
| upipe_interlace->tff ? "tff" : "bff"); | ||
| return UBASE_ERR_INVALID; |
Collaborator
There was a problem hiding this comment.
If an error is returned, the corresponding message should be an error message, not a warning.
nto
requested changes
Apr 10, 2026
Collaborator
nto
left a comment
nto
left a comment
There was a problem hiding this comment.
There is a typo in the commit message: "preform"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add upipe_interlace pipe to preform temporal field interlacing.