Skip to content

[k2] case insensitive comparing of connection header #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shamzik merged 3 commits into from
Apr 8, 2026
+7 −2
Merged

[k2] case insensitive comparing of connection header #1602

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4d0d32
[k2] case insensitive comparing of connection header
Shamzik Apr 7, 2026
93bb50b
add noexcept
Shamzik Apr 8, 2026
7d6fe06
IEQUALS
Shamzik Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions runtime-light/server/http/init-functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,14 @@ std::string_view process_headers(const tl::K2InvokeHttp& invoke_http, PhpScriptB
http_server_instance_st.encoding |= HttpServerInstanceState::ENCODING_DEFLATE;
}
} else if (h_name == kphp::http::headers::CONNECTION) {
if (h_value == CONNECTION_KEEP_ALIVE) [[likely]] {
static constexpr auto IEQUALS{[](std::string_view s1, std::string_view s2) noexcept {
return std::ranges::equal(s1, s2,
[](char a, char b) noexcept { return std::tolower(a, std::locale::classic()) == std::tolower(b, std::locale::classic()); });
}};

if (IEQUALS(h_value, CONNECTION_KEEP_ALIVE)) [[likely]] {
http_server_instance_st.connection_kind = kphp::http::connection_kind::keep_alive;
} else if (h_value == CONNECTION_CLOSE) [[likely]] {
} else if (IEQUALS(h_value, CONNECTION_CLOSE)) [[likely]] {
http_server_instance_st.connection_kind = kphp::http::connection_kind::close;
} else {
kphp::log::error("unexpected connection header: {}", h_value);
Expand Down
Loading