Repository navigation
Bench mode gated by the provisioning-token file; DEVICE_KEY_SECRET gone - #3
Merged
Merged
Conversation
… is gone Keys are minted by the Worker (valar-scopes docs/provisioning-mint.md), so the bench holds a PROVISION_TOKEN in ~/.config/valar-flasher/provision-token instead of the fleet secret. Bench mode refuses in one sentence without the file, checks presence only, and passes the file's PATH to the provisioner with --token-file (one path, never its contents). A test asserts the flasher never reads DEVICE_KEY_SECRET, with a control. Also: bench-loop tests get a 20 s deadline. The first sabotage run (drop --token-file) HUNG instead of going red -- a loop waiting for a count no failing board can reach. With the deadline: 8 red, as predicted; restored, 41 pass. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
origin/mainat8c547e349821a0b746142c5c667e2172ad148d4d, fetched and branched immediately before the commit.Companion to valar-scopes' Worker-minted keys (
docs/provisioning-mint.md). The bench holds a provisioning token, not the fleet secret.~/.config/valar-flasher/provision-tokenand refuses in one sentence without it. It checks presence only, and passes the file's path to the provisioner with--token-file, so there's one path and its contents are never handed over.valar_flasher.pynever readsDEVICE_KEY_SECRET. A test asserts that, with a control.--token-file, so every DONE in the tests also proves the flasher passed it.--token-file, hung instead of going red: a loop waiting for a count that no failing board can reach. It also left the file sabotaged until I restored it by hand and confirmed the restore.--token-file): 8 red, as predicted. Restored: green.🤖 Generated with Claude Code