simd: convert rshift64 macros to functions and fix simd_utils bugs#376
Merged
markos merged 1 commit intoVectorCamp:developfrom Apr 6, 2026
Merged
simd: convert rshift64 macros to functions and fix simd_utils bugs#376markos merged 1 commit intoVectorCamp:developfrom
markos merged 1 commit intoVectorCamp:developfrom
Conversation
Convert rshift64_m128/m256/m512 macros to inline functions that support runtime (non-constant) shift amounts on x86, matching the existing lshift64 function implementations. Also fix: - lshift64_m256/rshift64_m256 parameter type from int to unsigned in the non-256-bit fallback path (common/simd_utils.h) - isnonzero512: remove redundant self-OR operations - load512: fix alignment assertion to check m512 instead of m256 Fixes: 3f0f9e6 ("move x86 implementations of simd_utils.h to util/arch/x86/") Fixes: 6ff4752 ("add scalar versions of the vectorized functions for architectures that don't support 256-bit/512-bit SIMD vectors such as ARM") Fixes: 75aadb7 ("split arch-agnostic simd_utils.h functions into the common file") Signed-off-by: Byeonguk Jeong <jungbu2855@gmail.com>
byeonguk-jeong
force-pushed
the
simd-utils-fix
branch
from
fe83d25 to
8ce7f12
Compare
markos
approved these changes
Apr 6, 2026
markos
left a comment
markos
left a comment
There was a problem hiding this comment.
Nice, the remaining tests are because of SSE2 related issues on SIMDe emulated port. Thanks again for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert rshift64_m128/m256/m512 macros to inline functions that support runtime (non-constant) shift amounts on x86, matching the existing lshift64 function implementations.
Also fix:
Fixes: 3f0f9e6 ("move x86 implementations of simd_utils.h to util/arch/x86/")
Fixes: 6ff4752 ("add scalar versions of the vectorized functions for architectures that don't support 256-bit/512-bit SIMD vectors such as ARM")
Fixes: 75aadb7 ("split arch-agnostic simd_utils.h functions into the common file")
@AhnLab-OSS @AhnLab-OSSG