feat: improve reusability of operation form components #5133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: df0cd17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
therealemjy
force-pushed
the
feat/repay-collateral-tab
branch
4 times, most recently
from
e18dd33 to
1c5f5b2
Compare
therealemjy
force-pushed
the
refactor/operation-details-forms
branch
2 times, most recently
from
d571c4e to
a62e25d
Compare
Contributor
therealemjy
force-pushed
the
refactor/operation-details-forms
branch
from
a62e25d to
38fbf2e
Compare
therealemjy
force-pushed
the
refactor/operation-details-forms
branch
from
38fbf2e to
e24b5fc
Compare
therealemjy
force-pushed
the
refactor/operation-details-forms
branch
from
e24b5fc to
1ea2b60
Compare
therealemjy
force-pushed
the
refactor/operation-details-forms
branch
from
1ea2b60 to
df0cd17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
evm app
ApproveTokenandApproveDelegatecontainers to share between various forms that require an approval before submitting a transactionFootercomponent and implement it in the Supply form. In the following PRs, I'll refactor the other operation forms to use this component to remove some code duplicatesuseCommonValidationhook to be used on every operation details form to detect errors that are common among them