feat: aws cloudwatch metrics source - #306
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an enterprise AWS CloudWatch Metrics data source for the SRE agent: the
operator supplies only a region and least-privilege read access, and the agent
auto-discovers the account's CloudWatch metrics, learns a normal baseline per
(service, signal), and flags anomalies through the same training → shadow →detect lifecycle as the existing Prometheus metric source — zero alarms or metric
definitions authored by hand. Also threads the real metric source and unit through
to the Learned Signals view and ships several table UX improvements.
Why?
Extends the enterprise metric-intelligence capability to AWS-native teams that run
on CloudWatch instead of (or alongside) Prometheus, so they get learned baselines
and anomaly detection over their existing EC2 / RDS / ELB / ElastiCache / Lambda
metrics with no instrumentation work.
How to test
region-only
cloudwatch_metricssource and run the enterprise agent intrainingmode.Signals view shows the correct Source (CloudWatch), Unit, and a real
Service entity (instance / database / target — not an AZ, AMI, or roll-up).
shadow, thendetect, to see scoring and a real incident on asustained anomaly.
Type of change
Checklist
go test ./...passes locallygo vet ./...is cleangofmt'dsrc/if behavior changesROADMAP.mdif this closes a roadmap itemadds the AWS SDK for Go v2 CloudWatch client (read-only
ListMetrics+GetMetricData), required for the new source