Repository navigation
[PLAT-9529] - Vulnerability: api-client-node to axios v1.20.0 - #183
Merged
sksizer merged 2 commits intoOct 9, 2026
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
MadisonEhlers-Vertex
approved these changes
Oct 9, 2026
sksizer
deleted the
PLAT-9529-vulnerability-api-client-node-to-axios-v1-20-0
branch
October 9, 2026 11:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Agent:(claude-opus-5-5)Summary
This moves the SDK from axios 1.18.0 to 1.20.0, clearing the critical and high axios findings a customer reported against
@vertexvis/api-client-node0.44.0. It also bumps the package to 0.44.1 so the publish workflow releases it.package.json:"axios": "1.20.0"(still pinned exactly) and version0.44.1.yarn.lock: only the axios entry and itsform-data ^4.0.6range change.form-datastill resolves to 4.0.6 through the existing resolution.client/version.ts:0.44.1, synced byscripts/version.shthroughyarn version --no-git-tag-version. Nov0.44.1tag was created, sodetect_publish.shwill publish on merge.common.ts: addsas Promise<R>onaxios.request. axios 1.20.0's types madetscfail here with TS2527 (an inferred type references an unexportedunique symbol). The same fix is added toscripts/generate.shas a post-generationsed, alongside the existing ones, so regenerating the client keeps it. The published declarations match 0.44.0, apart from axios's own new defaulted fourth type parameter onAxiosResponse.Test Plan
yarn install --frozen-lockfile: passed.yarn lint: passed.yarn verify: passed. This covers the CJS and ESM builds, jest (10/10) andverify.js.yarn audit --groups dependencies: before, 12 axios advisories (7 high, 5 moderate, all patched in >=1.20.0); after, 0 vulnerabilities.npm pack: the tarball is0.44.1, and itspackage.jsondeclares axios 1.20.0.dist/cjs/*.d.tsagainst the 0.44.0 tarball from npm. The only change is axios's defaulted type parameter.user-agent: vertex-api-client-node/0.44.1headers,timeoutand a keep-alivehttpAgentthroughaxiosOptions,createFileplus anapplication/octet-streamupload with a byte-identical body,getFile,deleteFile, and a 404 surfaced through the response interceptor.Release Notes
@vertexvis/api-client-node0.44.1 updates its HTTP client dependency, axios, to 1.20.0, resolving the critical and high security advisories reported against axios 1.18.0. There are no API changes: upgrade the dependency and refresh your lockfile.Possible Regressions
axios.createinstance, one response interceptor, basic and Bearer auth, and octet-stream uploads. None of these touch the changed behavior; this is inferred from the release notes and was exercised against the mock.CancelToken, used by queued-job polling, still exists in 1.20.0.Dependencies
Related
Note
Medium Risk
Upgrading axios affects all HTTP traffic through the SDK; risk is moderated by a patch-level dependency bump and a type-only workaround, but runtime behavior could still shift with axios 1.19–1.20 hardening.
Overview
Patches @vertexvis/api-client-node to 0.44.1 and upgrades the pinned axios dependency from 1.18.0 to 1.20.0, addressing reported critical/high advisories on the prior version (lockfile updates include axios’s form-data range).
axios 1.20.0’s typings break compilation in
createRequestFunction(common.ts); the PR addsas Promise<R>onaxios.requestand mirrors that inscripts/generate.shso regenerated clients keep the fix. No public API surface changes beyond the version bump.Reviewed by Cursor Bugbot for commit fb7dc2f. Bugbot is set up for automated code reviews on this repo. Configure here.