This repository was archived by the owner on Aug 11, 2025. It is now read-only.
Open
Conversation
This change updates the proposed API to use IdentityCredential instead.
default criticality to true
davidz25
reviewed
Mar 30, 2023
| ], | ||
| }], | ||
| } | ||
| }; |
There was a problem hiding this comment.
For compatibility with DeviceRequest in 18013-5, I would prefer that we default to critical being false and that's also how I read MdocRequestedElement. Your example suggests it's the other way around though.
|
Seemingly targets #9. |
rektide
reviewed
Apr 23, 2023
Comment on lines
+183
to
+186
| scheme: “mdoc”, | ||
| nonce: "gf69kepV+m5tGxMyMF0cnn9NCnRHez/LUIsFtLi6pwg=", | ||
| documentType: "org.iso.18013.5.1.mDL", | ||
| readerPublicKey: "ftl+VEHPB17r2oi6it3ENaqhOOB0AZbAkb5f4VlCPakpdNioc9QZ7X/6w...", |
There was a problem hiding this comment.
Most of these keys are new (documentType excepted). Do these changes have to do with the subject of this PR, "Criticality"? If so, how?
In general, this PR has almost no description to it. Can we please add a PR description talking about what changes there are here?
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.