Skip to content
This repository was archived by the owner on Dec 8, 2025. It is now read-only.

fix: logging#8

Open
chris13524 wants to merge 2 commits intomainfrom
fix-logging
Open

fix: logging#8
chris13524 wants to merge 2 commits intomainfrom
fix-logging

Conversation

@chris13524
Copy link
Member

@chris13524 chris13524 commented Feb 8, 2023

Description

Add /metrics endpoint, following how its done in echo-server, to resolve ECS logging errors.

How Has This Been Tested?

cargo +nightly fmt && cargo +nightly clippy
terraform -chdir=terraform fmt -recursive

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

Copy link
Contributor

@HarryET HarryET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just saw this in review requests - please fmt before merging though

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants