ci(spark): add GitLab CI pipeline (test + build) — Story 7.4 - #2
Draft
WarutC wants to merge 2 commits into
Draft
Conversation
Story 7.4 — test/build only on GitLab CI; deploy stays on GH Actions until 10.3. - test: lint + jest via workspaces with --if-present - build: npm run build, artifact packages/scratch-gui/build (7-day expiry) - node:24 to match .nvmrc; node_modules cached on ref + lockfile Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…cache) Per the Story 7.4 code review (2026-05-27), 2 patches in this submodule: - Add `--if-present` to `npm test --workspaces` so workspaces without a `test` script (asset / tooling packages) don't break the pipeline. Parity with the lint line above which already uses --if-present. - Drop the `node_modules/` cache — `npm ci` wipes node_modules on every run, so caching it is wasted I/O and risks cross-MR poisoning within the same branch. Cache `~/.npm` (npm's download cache) instead via `npm_config_cache` env var; `npm ci --prefer-offline` uses it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story 7.4 — scratch-editor slice. See parent MR on GitLab for cross-submodule context.
Summary
.gitlab-ci.yml— test + build only, no deploy.test:npm ci→npm run lint --workspaces --if-present→npm test --workspaces.build:npm run build→ artifactpackages/scratch-gui/build/(7-day expiry).node:24image to match.nvmrc;node_modulescached on ref + lockfile.--workspaces --if-present(no top-level lint script today — out of scope for 7.4).Scope discipline
.github/workflows/deploy-uat.yml) until Story 10.3 migrates the image build/push to GitLab Container Registry + ArgoCD..github/workflows/*.Note
This branch lives on GitHub but the project's CI/CD platform is GitLab (per SCP-2026-05-25). The
.gitlab-ci.ymlhere ships so that when 10.3 retiresdeploy-uat.ymland the repo migrates fully to GitLab, the test/build pipeline is already in place.Test plan
test+build..github/changes).npm ci && npm test && npm run build(workspace-wide).🤖 Generated with Claude Code