Repository navigation
test: run the hammer cases on the test clock - #92
Merged
Merged
Conversation
oschaaf
force-pushed
the
test/stripe-sizing-test-clock
branch
from
October 30, 2026 09:48
16c6217 to
6425481
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the cross-view hammer case from #67 (and its single-process twin) off wall time.
LeaseTestClock::advanceis now safe from any thread (a relaxed atomic add, so the clock adds no synchronization between threads and ThreadSanitizer still sees the lease protocol's own ordering), which the hammer needs."Auto stripe sizing keeps writes flowing" was already moved to the test clock in #90, so the rest of #67 is covered here.
Verification (Linux, GCC 13, Release):
ctest -j12 --timeout 300three times in a row: 921 tests, 100% passed each time. With three full suites running at once on the same 12 cores, plus 15 further runs of the hammer cases: 0 hammer failures. Two other tests failed in that overloaded run (the LRU concurrent get+put case and the seqlock wall-time bound); both are wall-time-bound cases (the LRU one has been added to #91) and are not touched here.CI is unchanged. The macOS job stays single-process: that workaround is for a hang of a parallel run on its 3-core runner, which this test-clock change does not address.
Fixes #67
Refs #91