Split Inlining: Handle return_calls in Pattern B, not just returns #8159
+145
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Dec 30, 2025
| ReturnCallersMap findReturnCallers(Module& wasm); | ||
|
|
||
| // Information about the returns in a given expression. | ||
| struct Info { |
Member
There was a problem hiding this comment.
Even though this is in the ReturnUtils namespace, I think it would be better to use e.g. ReturnInfo or some other more descriptive name (ReturnPresence? HasReturn?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pattern B needs to exclude code with returns at some point. It did so by
finding Returns, but ever since tail calls, there are other kinds of returns
as well. Refactor some ReturnUtils code to find all returns, including
return_calls, and use that.
Diff without whitespace is smaller.