Fix unintentional macro shadowing in json.h #8162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json.h defines two lambdas with the same name link. From #8086, the calls in json.h are macro-expanded rather than using the lambdas defined there. This is coincidentally ok because they have the exact same definition, but results in an unused variable warning for the two lambdas. This happens in #8086 and not in main because that PR adds
#include "ir/memory-utils.h"in wasm-interpreter.h which probably results in simple_ast.h being included before json.h which causes the shadowing.Without this PR. With this PR, compilation succeeds.