Define and package the curated application face - #1
Merged
Conversation
Generate declarations, request metadata, and the searchable member index from the same pinned Discovery inputs so the typechecker, sandbox installer, and applications tool cannot drift. Keep native Drive transfer behavior and the existing auth owner behind the product package, and prove the final face through contract and real-browser tests.
Join each package's card, searchable members, and related skills behind one structural contract while leaving installers, authentication, and request semantics product-owned. Generate Google call prefixes and output descriptions so the host no longer has to reconstruct package metadata.
Keep shipped Google application facts in one package-owned contract: member effects are required, availability carries the native-files capability, and generated members derive from the shared face type. Narrow the generated transport metadata, validate the Drive files resource instead of casting it, and expose only the supported package root so host consumers cannot couple to generated internals.
Move the Google application identity, ambient execution binding, and installer boundary types into the package that owns them. This leaves Rook responsible only for Chrome authority and runtime orchestration.\n\nShip deterministic browser ESM and declarations because Git commit installs run with lifecycle scripts disabled. Validate the actual tarball through a clean Node import and TypeScript consumer so npm readiness is tested at the public boundary.
Google requires uploadType=multipart on the /upload URI. Binary files happened to survive the omitted mode, but text uploads could be created as empty Drive files. Set the required query parameter and exercise text bytes through the real Chromium multipart boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Rook needs one small package contract for curated applications without forcing every provider into a universal runtime adapter. The package should own provider identity, model-facing types, client behavior, authoritative inputs, and browser proof; the extension should own Chrome authority, sandbox lifecycle, and transport routing.
This is the package-side dependency for rook#135, which pins the exact reviewed commit.
The generated Google surface continues to come from the Google API Discovery Service. The published entrypoint follows Node's package entry point contract with executable ESM and bundled declarations rather than TypeScript source under
node_modules.What changed
ApplicationsNamespacebinding alongside the client types..d.tsartifacts with Vite+ while retaining the source, skills, and authoritative Discovery inputs needed by Rook's immutable Git pin.Verification
vp run checkRelease scope
GraphQL and additional providers remain intentionally excluded. Changesets and npm trusted-publishing automation should land only when the
@rooktrusted publisher is configured.