Skip to content

Updated CESR 2.0 code tables to match keripy - #161

Draft
daidoji wants to merge 3 commits into
WebOfTrust:mainfrom
daidoji:feature/update-cesr-1.0
Draft

Updated CESR 2.0 code tables to match keripy#161
daidoji wants to merge 3 commits into
WebOfTrust:mainfrom
daidoji:feature/update-cesr-1.0

Conversation

@daidoji

@daidoji daidoji commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

Rationale

Starting work on upgrading CESR to 2.0 version as detailed in #160

Testing

Updated naive code table tests but that's about it. Still have questions about how cesride was tested against keripy in #cesr channel on discord.

For Reviewers

  • Verify version bumped in Cargo.toml

@codecov

codecov Bot commented Dec 6, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.47%. Comparing base (7cd5453) to head (336469d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   95.42%   95.47%   +0.04%     
==========================================
  Files          32       32              
  Lines        3037     3069      +32     
==========================================
+ Hits         2898     2930      +32     
  Misses        139      139              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daidoji daidoji changed the title WARNING: Doesn't pass tests, may not build Updated CESR 2.0 code tables to match keripy Dec 6, 2023
@daidoji
daidoji marked this pull request as ready for review December 6, 2023 15:07
@daidoji

daidoji commented Dec 7, 2023

Copy link
Copy Markdown
Collaborator Author

Changing to draft, this work is on hold until Sam completes work. WebOfTrust/cesr-ts#17 (comment)

@daidoji
daidoji marked this pull request as draft December 7, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant