feat: add generic /verify endpoint - #454
Draft
Sotatek-Patrick-Vu wants to merge 4 commits into
Draft
Conversation
Sotatek-Patrick-Vu
force-pushed
the
feat/verify
branch
from
July 24, 2026 03:00
dca5b05 to
bf5710c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
+ Coverage 87.76% 88.53% +0.76%
==========================================
Files 26 26
Lines 5826 5973 +147
==========================================
+ Hits 5113 5288 +175
+ Misses 713 685 -28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
iFergal
reviewed
Jul 24, 2026
|
|
||
| ced = op.metadata["ced"] | ||
| if self.credentialer.complete(ced["d"]): | ||
| if self.credentialer.rgy.reger.saved.get(keys=ced["d"]) is not None: |
Collaborator
There was a problem hiding this comment.
credentialer.complete only works for credentials we issue - looking at the escrows, there isn't really much difference right now compared to reger.saved which would allow this op type to be used for general verification of credentials too.
Not sure if this would change when we have deployed registrars is the only thing. Happy to split to two if we think that'd be better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /credentials/verify was previously used to verify a credential from Signify for use cases where ACDCs are published somewhere and indexed, such as a blockchain, rather than direct IPEX engagements.
We would like to supersede the endpoint with a more generic /verify endpoint which accepts a serder + attachment and returns the relevant long running operation - ACDC + TEL events supported for now.
Draft PR for now; looking for feedback on general approach.