Backport to v1.2.14: fix: full size of 1AAE should be 156, not 56 - #1601
Merged
kentbull merged 1 commit intoAug 12, 2026
Merged
Conversation
kentbull
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports to
v1.2.14frommainDaniel's fix to the CESR code table for an Ed448 signature.Reference PR: #893
Rationale (copied):
An Ed448 signature is 114 bytes (binary). When serialized as CESR, there's a 4/3 increase in size, and a prefix. The correct size of this primitive in CESR is 156 bytes, which is what the spec claims, not 56 bytes as currently shown in the Matter class in keripy.
Fixes #892