Skip to content

Tests: End the About CSS slice at the next section, not a named one #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmtr merged 2 commits into from
Aug 21, 2026
Merged

Tests: End the About CSS slice at the next section, not a named one #646

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bdcd3a
Tests: End the About CSS slice at the next section, not a named one
mmtr Aug 21, 2026
0c4201f
Update os-settings-about-theme.test.ts
mmtr Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/vitest/os-settings-about-theme.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ import { describe, expect, test } from 'vitest';
const root = join( __dirname, '../..' );
const css = readFileSync( join( root, 'assets/css/os-settings.css' ), 'utf8' );
const aboutStart = css.indexOf( '/*\n * About tab' );
const aboutEnd = css.indexOf( '/* Apps & Icons section', aboutStart );
const nextSection = css.indexOf( '\n/*', aboutStart + 1 );
const aboutEnd = -1 === nextSection ? css.length : nextSection;
const aboutCss = css.slice( aboutStart, aboutEnd );

describe( 'OS Settings — About theme contract', () => {
Expand Down