Add a new error message for non-zero exit codes to lint hook in justfile#5566
Open
CharlesKnell wants to merge 1 commit into
Open
Add a new error message for non-zero exit codes to lint hook in justfile#5566CharlesKnell wants to merge 1 commit into
CharlesKnell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2441 by @CharlesKnell
Description
In justfile, the lint hook will issue the following message when a non-zero exit code is encountered:
"error: Recipe 'lint' failed. Look above this line for the exact error."
Currently, the message would be similar to the following:
"error: Recipe
lintfailed on line 92 with exit code 1"Testing Instructions
To generate a lint error, execute the following:
ov sudo chmod o-rwx /opt
ov just lint
To remove the lint error, execute the following:
ov sudo chmod o+rwx /opt
ov just lint
Checklist
Update index.md).main) or a parent feature branch.ov just catalog/generate-docsfor catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-propsfor the catalog or
ov just api/generate-docsfor the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin