Skip to content

fix(automations): make !reportData.length guard work correctly for last_week_tonight#5575

Open
Copilot wants to merge 2 commits into
mainfrom
copilot/return-early-no-meaningful-content
Open

fix(automations): make !reportData.length guard work correctly for last_week_tonight#5575
Copilot wants to merge 2 commits into
mainfrom
copilot/return-early-no-meaningful-content

Conversation

Copy link
Copy Markdown

Copilot AI commented May 11, 2026

getItemsHtml groups items by 🧱 stack:* label and silently drops anything without one. This meant repos with issues/PRs that all lacked stack labels still entered reportData, bypassing the !reportData.length early-exit and producing a contentless post (only <h2>/<h3> headings, no links).

Description

  • Added hasStackLabel predicate and applied it as a .filter() on both closedIssues and mergedPrs at collection time, so reportData only contains repos with at least one renderable item
  • The existing !reportData.length guard now correctly prevents posting when there's nothing to show
  • Removed the <li>-string-check workaround that had been added to postActivities — now redundant
const hasStackLabel = (item) =>
  item.labels.some((label) => label.name.startsWith("🧱 stack"))

// Only items that will actually render enter reportData
const closedIssues = (...).data.items.filter(hasStackLabel)
const mergedPrs    = (...).data.items.filter(hasStackLabel)

Testing Instructions

Run the script against a date range where repos have closed issues/PRs but none carry a 🧱 stack:* label; confirm it logs "Nothing to post about, exiting." and makes no POST request.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dd32
Copy link
Copy Markdown
Member

dd32 commented May 11, 2026

This is a followup to #5344 as I noticed empty status updates being posted: https://make.wordpress.org/openverse/2026/05/11/last-week-openverse-2026-05-04-2026-05-11/

@dd32 dd32 marked this pull request as ready for review May 11, 2026 01:33
@dd32 dd32 requested a review from a team as a code owner May 11, 2026 01:33
@dd32 dd32 requested review from dhruvkb, krysal and obulat and removed request for a team May 11, 2026 01:33
@openverse-bot openverse-bot moved this to 👀 Needs Review in Openverse PRs May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 Needs Review

Development

Successfully merging this pull request may close these issues.

3 participants