Add a counter to filter button and tab#826
Merged
Merged
Conversation
openverse-bot
added
🟨 priority: medium
|
Full-stack documentation: Ready https://WordPress.github.io/openverse/_preview/826 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
obulat
force-pushed
the
add/filter_counter
branch
3 times, most recently
from
abf3ceb to
6dc88c5
Compare
obulat
force-pushed
the
add/filter_counter
branch
3 times, most recently
from
da46b23 to
9a243f5
Compare
fcoveram
reviewed
Mar 13, 2023
| <VIcon v-if="showIcon" :icon-path="filterIcon" /> | ||
| <p | ||
| v-else | ||
| class="flex h-6 w-6 items-center justify-center" |
Contributor
There was a problem hiding this comment.
The counter needs to have a corner radius of 2px. I think the class is rounded-sm.
Contributor
|
The filter looks great ✨ I just noticed two things:
|
obulat
force-pushed
the
add/filter_counter
branch
from
4908874 to
d1dd32d
Compare
zackkrida
approved these changes
Mar 13, 2023
Member
zackkrida
left a comment
zackkrida
left a comment
There was a problem hiding this comment.
The code and visuals look good to me, but I'd like to make sure someone accessibility-minded can look at this, specifically for the aria label. Previously, the button was labeled "Filters" and its purpose is to toggle the filter sidebar open or closed. Now, it also indicates how many filters are enabled at a given time.
I wonder if the aria label should be something like "Toggle filters (5 enabled)" instead of the current "5 filters" 🤔
|
Size Change: +619 B (0%) Total Size: 882 kB
ℹ️ View Unchanged
|
obulat
force-pushed
the
add/filter_counter
branch
from
78b537c to
2ecd370
Compare
obulat
force-pushed
the
add/filter_counter
branch
from
2ecd370 to
085f7e7
Compare
Contributor
Author
I am going to open an issue for better accessibility of the filters button and tab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #482 by @panchovm
Description
This PR adds the counter to the filters button and tab according to the Mockups in Figma
It is the same as WordPress/openverse-frontend#2143, with the gray square on hover (reported by @zackkrida) fixed.
Testing Instructions
When you select filters, the number of selected filters should appear on the button (desktop) or the tab (mobile).
I've added some Storybook snapshot tests and Playwright VR snapshot tests.
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin