Skip to content

Move symbols to their own files - #409

Merged
adamziel merged 1 commit into
trunkfrom
arc-1813-move-symbols
Aug 3, 2026
Merged

Move symbols to their own files#409
adamziel merged 1 commit into
trunkfrom
arc-1813-move-symbols

Conversation

@atanas-dev

Copy link
Copy Markdown
Collaborator

No description provided.

@atanas-dev atanas-dev self-assigned this Jul 29, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Pull pipeline performance — large-directory

Site: large-directory · 2,000+ plus targeted file-transfer scenarios files · 10,000 posts · 25,000 postmeta · PHP 8.5.9

Stage PR trunk Δ Status Details
playground-sqlite-db-pull 9.55 s 9.46 s ⚪ +88 ms (+0.9%) condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
trunk: condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
playground-sqlite-db-apply 3.54 s 3.55 s ⚪ -6 ms (-0.2%) condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
trunk: condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
Total 13.09 s 13.00 s ⚪ +82 ms (+0.6%)

Numbers carry runner noise; treat single-run deltas as directional, not authoritative.

📈 Trunk performance history — commit-by-commit timeline.

@atanas-dev
atanas-dev force-pushed the arc-1813-move-symbols branch from a70b8e0 to c655a7b Compare July 29, 2026 09:27
@atanas-dev
atanas-dev requested review from WPprodigy and adamziel July 29, 2026 12:58
@adamziel

Copy link
Copy Markdown
Collaborator

Could we rebase this on trunk? It seems to be only moving the existing code around and, as such, is a risk-free change that we could easily get in. #394, on the other hand, I'm not convinced about and I'd like to challenge some assumptions in there, and we may end up discussing it for a while. There's no need to block this PR on that.

@atanas-dev
atanas-dev force-pushed the arc-1813-move-symbols branch from c655a7b to 5d118ab Compare July 30, 2026 11:54
@atanas-dev
atanas-dev changed the base branch from arc-1813-cli to trunk July 30, 2026 11:56
@atanas-dev
atanas-dev force-pushed the arc-1813-move-symbols branch from 5d118ab to 0033857 Compare July 30, 2026 12:23
@atanas-dev

Copy link
Copy Markdown
Collaborator Author

@adamziel done :)

@adamziel

Copy link
Copy Markdown
Collaborator

Nice, thank you! I'm merging some wording changes that are creating conflicts here, let's connect synchronously tomorrow to get this merged

@atanas-dev
atanas-dev force-pushed the arc-1813-move-symbols branch 2 times, most recently from 4977914 to 1b6e2e2 Compare July 31, 2026 14:19
@atanas-dev
atanas-dev force-pushed the arc-1813-move-symbols branch from 1b6e2e2 to 30705d1 Compare August 3, 2026 10:20
@adamziel
adamziel merged commit 9df0878 into trunk Aug 3, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants