[PHP] Preserve decoded URL suffixes in structured block markup - #570
Open
adamziel wants to merge 1 commit into
Open
[PHP] Preserve decoded URL suffixes in structured block markup#570adamziel wants to merge 1 commit into
adamziel wants to merge 1 commit into
Conversation
Contributor
Pull pipeline performance —
|
| Stage | PR | trunk | Δ | Status | Details |
|---|---|---|---|---|---|
playground-sqlite-db-pull |
10.05 s | 9.77 s | ⚪ +273 ms (+2.8%) | ✓ | condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected trunk: condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected |
playground-sqlite-db-apply |
3.82 s | 3.81 s | ⚪ +16 ms (+0.4%) | ✓ | condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified trunk: condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified |
| Total | 13.87 s | 13.58 s | ⚪ +289 ms (+2.1%) |
Numbers carry runner noise; treat single-run deltas as directional, not authoritative.
📈 Trunk performance history — commit-by-commit timeline.
adamziel
force-pushed
the
codex/preserve-url-suffix-bytes
branch
from
August 13, 2026 15:52
66a5bda to
71f935e
Compare
adamziel
force-pushed
the
codex/preserve-url-suffix-bytes
branch
2 times, most recently
from
August 13, 2026 21:40
153fe63 to
d0e7cd0
Compare
adamziel
force-pushed
the
codex/preserve-url-suffix-bytes
branch
from
August 14, 2026 00:02
d0e7cd0 to
ec4a8f7
Compare
adamziel
force-pushed
the
codex/preserve-url-suffix-bytes
branch
from
August 14, 2026 12:52
ec4a8f7 to
7a45b45
Compare
adamziel
force-pushed
the
codex/preserve-url-suffix-bytes
branch
from
August 14, 2026 21:22
7a45b45 to
5ed660e
Compare
adamziel
changed the base branch from
trunk
to
codex/structured-block-markup-processor
August 14, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structured block URLs now replace only the mapped scheme, authority, and pathname prefix in the decoded URL value. The unmatched path, query, and fragment bytes reach the existing HTML, CSS, or block serializer unchanged.
StructuredBlockMarkupUrlProcessorusesWPURL::replace_base_url()as the semantic result, locates only source boundaries marked by literal delimiters, and reparses the edited URL before accepting it. Ambiguous source spellings stay unchanged, and the cautious token pass is skipped for that token so it cannot bypass the failed boundary check.The rewriter caches only the selected mapping index. Each occurrence still computes its own source-preserving URL, so equal parsed URLs with different source spellings do not share rendered output. The selected mapping’s own source base is used instead of the first configured base.
This is stacked on #625.
Testing
The URL-rewriting suite passes with 430 tests and 2,716 assertions (7 pre-existing skips). PHPStan, PHPCompatibility 7.4+, targeted PHPCS, and
git diff --checkpass.