Skip to content

[Pull] Preserve selected symlinked directories selected with --only - #572

Open
fredrikekelund wants to merge 1 commit into
trunkfrom
symlinked-only-directory-root
Open

[Pull] Preserve selected symlinked directories selected with --only#572
fredrikekelund wants to merge 1 commit into
trunkfrom
symlinked-only-directory-root

Conversation

@fredrikekelund

Copy link
Copy Markdown
Collaborator

files-pull --only=<path> now recreates <path> when it is a symlink to a directory, so a scoped pull leaves the selected plugin available at the path the user requested.

For example, a site may contain:

wp-content/plugins/akismet -> ../../../wordpress/plugins/akismet/5.7

Before this change, pulling only that plugin indexes and downloads wordpress/plugins/akismet/5.7/ but leaves wp-content/plugins/akismet absent under --fs-root. After this change, the pull also recreates wp-content/plugins/akismet with the same relative target spelling, so the selected plugin resolves locally.

Note

This is Codex through and through. This issue was identified in Automattic/studio#4491, then verified, planned, implemented, and tested by my agent.

@github-actions

Copy link
Copy Markdown
Contributor

Pull pipeline performance — large-directory

Site: large-directory · 2,000+ plus targeted file-transfer scenarios files · 10,000 posts · 25,000 postmeta · PHP 8.5.9

Stage PR trunk Δ Status Details
playground-sqlite-db-pull 9.57 s 9.57 s ⚪ -1 ms (-0.0%) condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
trunk: condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
playground-sqlite-db-apply 3.52 s 3.57 s ⚪ -49 ms (-1.4%) condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
trunk: condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
Total 13.09 s 13.13 s ⚪ -49 ms (-0.4%)

Numbers carry runner noise; treat single-run deltas as directional, not authoritative.

📈 Trunk performance history — commit-by-commit timeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant