[PHP] Extract resumable fresh local index processing from PushPlan - #576
Closed
adamziel wants to merge 1 commit into
Closed
[PHP] Extract resumable fresh local index processing from PushPlan#576adamziel wants to merge 1 commit into
adamziel wants to merge 1 commit into
Conversation
Contributor
Pull pipeline performance —
|
| Stage | PR | trunk | Δ | Status | Details |
|---|---|---|---|---|---|
playground-sqlite-db-pull |
10.12 s | 9.71 s | ⚪ +404 ms (+4.2%) | ✓ | condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected trunk: condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected |
playground-sqlite-db-apply |
3.85 s | 3.81 s | ⚪ +37 ms (+1.0%) | ✓ | condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified trunk: condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified |
| Total | 13.96 s | 13.52 s | ⚪ +441 ms (+3.3%) |
Numbers carry runner noise; treat single-run deltas as directional, not authoritative.
📈 Trunk performance history — commit-by-commit timeline.
adamziel
force-pushed
the
codex/share-fresh-local-index
branch
from
August 13, 2026 19:45
a007aea to
1adfe02
Compare
Collaborator
Author
|
Superseded by a single minimal PR based directly on trunk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves fresh local index construction out of
PushPlanso pull and push can use the same resumable filesystem scan.FreshLocalIndexProcessorownsFileIndexProcessor, the fresh local index file, its saved byte offset, and the final sort. Its cursor contains every value needed byresume():PushPlannow stores that cursor unchanged. It keeps the existing phase boundary between traversal and sorting, then startsFileSyncPatchPlannerexactly as before. The raw traversal, JSONL writing, output truncation, and sorting code are removed fromPushPlan.Testing
The focused tests cover sorted local-relative index entries, empty directories, resume after an uncommitted output tail, the separate sorting step, PushPlan behavior, bounded sender steps, and process-death resume.