[PHP] Keep pulled deletions within selected paths - #585
Closed
adamziel wants to merge 1 commit into
Closed
Conversation
Contributor
Pull pipeline performance —
|
| Stage | PR | trunk | Δ | Status | Details |
|---|---|---|---|---|---|
playground-sqlite-db-pull |
9.45 s | 9.41 s | ⚪ +43 ms (+0.5%) | ✓ | condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected trunk: condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected |
playground-sqlite-db-apply |
3.65 s | 3.62 s | ⚪ +25 ms (+0.7%) | ✓ | condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified trunk: condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified |
| Total | 13.10 s | 13.03 s | ⚪ +68 ms (+0.5%) |
Numbers carry runner noise; treat single-run deltas as directional, not authoritative.
📈 Trunk performance history — commit-by-commit timeline.
adamziel
force-pushed
the
codex/selection-aware-remote-deletion
branch
from
August 13, 2026 23:34
93c2ec0 to
45df39c
Compare
adamziel
force-pushed
the
codex/selection-aware-remote-deletion
branch
from
August 13, 2026 23:50
45df39c to
076db24
Compare
Collaborator
Author
|
Superseded by a single minimal PR based directly on trunk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled remote deletions now stop at the active include, exclude, and remap boundaries.
For example, when
/var/www/htmlis remapped tositeand that whole remote tree disappears, the sparse index can identify/varas the first absent parent. Pull now stops at/var/www/htmland removessiteinstead of mapping/varto an unrelated local path. An excluded descendant or a separate remap target also keeps a broader parent from being deleted.FileSyncPatchPlannerand files-pull now use the same sparse-index deletion rule. When a former empty-directory entry is replaced by a descendant, pull removes the stale index entry without removing the directory.Testing
The focused tests cover nested includes, excluded descendants, complete remapped-tree deletion, overlapping local remap targets, and an empty directory becoming non-empty.