[PHP] Add exact local cleanup to file sync patches - #587
Open
adamziel wants to merge 1 commit into
Open
Conversation
Contributor
Pull pipeline performance —
|
| Stage | PR | trunk | Δ | Status | Details |
|---|---|---|---|---|---|
playground-sqlite-db-pull |
10.27 s | 9.59 s | ⚪ +678 ms (+7.1%) | ✓ | condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected trunk: condition=db-pull in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=lexer native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=selected |
playground-sqlite-db-apply |
3.75 s | 3.74 s | ⚪ +17 ms (+0.5%) | ✓ | condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified trunk: condition=db-apply to SQLite in PHP.wasm runtime=php.wasm 8.3 wp_mysql_parser=enabled mode=parser native_lexer=verified native_token_stream=WP_MySQL_Native_Token_Stream native_token_count=18 native_parser=verified native_ast=WP_MySQL_Native_Parser_Node sqlite_driver_parser=verified |
| Total | 14.02 s | 13.33 s | ⚪ +695 ms (+5.2%) |
Numbers carry runner noise; treat single-run deltas as directional, not authoritative.
📈 Trunk performance history — commit-by-commit timeline.
adamziel
force-pushed
the
codex/share-file-sync-cleanup
branch
from
August 14, 2026 01:25
a6e41d5 to
688f690
Compare
adamziel
force-pushed
the
codex/share-file-sync-cleanup
branch
from
August 14, 2026 01:39
688f690 to
c628e01
Compare
adamziel
changed the base branch from
codex/selection-aware-remote-deletion
to
codex/share-file-index-path-inspection
August 14, 2026 01:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File sync cleanup can now remove selected indexed paths without removing skipped or excluded children.
FileSyncPatchProcessor::start_from_fresh_local_tree()plans exact deletions. The push direction keeps collapsing deleted subtrees to one root.FileSyncCleanupProcessorremoves one exact file, link, or empty directory per step. It usesunlink()andrmdir()and never walks a directory recursively. If a cache, storage, excluded, or newly created child remains, its parent remains too. After the exact removals, cleanup prunes one unchanged empty parent per step.The cursor stores a pending removal and the local type, size, and ctime seen by the fresh scan. Cleanup checks those fields before removing the path. If they changed, it returns
restartand leaves the new path alone.