Skip to content

[PHP] Record remote sizes for pulled symlinks - #596

Closed
adamziel wants to merge 1 commit into
codex/read-remote-directory-shapefrom
codex/record-pulled-symlink-size
Closed

[PHP] Record remote sizes for pulled symlinks#596
adamziel wants to merge 1 commit into
codex/read-remote-directory-shapefrom
codex/record-pulled-symlink-size

Conversation

@adamziel

Copy link
Copy Markdown
Collaborator

Pulled symlinks now retain the remote target's byte length in the remote index.

The next remote index gets a symlink's size from remote lstat(). Fetch later wrote size 0 into the pull index WAL, so applying that record changed the metadata of an otherwise unchanged symlink. This records strlen($target) from the decoded remote target. It deliberately does not use the rewritten local target, whose length may differ after path mapping.

Testing

The symlink pull test checks the WAL record and the existing symlink cases continue to pass.

@github-actions

Copy link
Copy Markdown
Contributor

Pull pipeline performance — large-directory

Site: large-directory · 2,000+ plus targeted file-transfer scenarios files · 10,000 posts · 25,000 postmeta · PHP 8.5.9

Stage PR trunk Δ Status Details
playground-sqlite-db-pull 8.12 s 7.96 s ⚪ +160 ms (+2.0%) condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
trunk: condition=db-pull in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=lexer
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=selected
playground-sqlite-db-apply 3.29 s 3.22 s ⚪ +75 ms (+2.3%) condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
trunk: condition=db-apply to SQLite in PHP.wasm
runtime=php.wasm 8.3
wp_mysql_parser=enabled
mode=parser
native_lexer=verified
native_token_stream=WP_MySQL_Native_Token_Stream
native_token_count=18
native_parser=verified
native_ast=WP_MySQL_Native_Parser_Node
sqlite_driver_parser=verified
Total 11.42 s 11.18 s ⚪ +236 ms (+2.1%)

Numbers carry runner noise; treat single-run deltas as directional, not authoritative.

📈 Trunk performance history — commit-by-commit timeline.

@adamziel

Copy link
Copy Markdown
Collaborator Author

Superseded by a single minimal PR based directly on trunk.

@adamziel adamziel closed this Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant