feat(base-transport-json): replace Jackson with base-json#55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
base-transport-jsonoff the Jackson streaming API (JsonGenerator/JsonParser) and onto thebase-jsontyped value model introduced in #54. TheCodecinterface gainsencode/decodemethods that operate onJsonValueinstead ofvoidwrite/read methods that mutated a streaming generator/parser, all codec implementations simplify dramatically as a result, andJsonTransportitself drops itsrequires com.fasterxml.jackson.coremodule dependency entirely. Jackson is removed from the root BOM. CheckedIOExceptionis replaced with uncheckedIllegalStateExceptionthroughout, since codec failures are programming errors rather than I/O failures. The polymorphic type discriminator field is renamed from"type"to"@type"to prevent silent key collisions with marshalled objects that have a field of the same name.