Skip to content
This repository was archived by the owner on May 16, 2024. It is now read-only.

Added new Baro Settings popup to the G3X Touch. - #741

Open
arron-h wants to merge 1 commit into
Working-Title-MSFS-Mods:mainfrom
arron-h:g3x_baro_settings_popup
Open

arron-h wants to merge 1 commit into
Working-Title-MSFS-Mods:mainfrom
arron-h:g3x_baro_settings_popup

Conversation

@arron-h

@arron-h arron-h commented Dec 31, 2020

Copy link
Copy Markdown

This is activated by clicking on the baro reference value under the altimeter.
In order to bring this popup up, an ID was required to be added to the baro reference text in the shared Altimeter.js.

kingair_baro_set

@arron-h

arron-h commented Dec 31, 2020

Copy link
Copy Markdown
Author

Validation on the input is performed. As can be seen, the Enter button is greyed out. The Enter button activates when a valid pressure setting (ranging from 27.99 to 32.01) is input. Clicking Set Standard fills in 29.92 and activates the Enter button.

@cwburnett
cwburnett requested a review from kaosfere December 31, 2020 20:59
@arron-h arron-h changed the title Added new Baro Settings popup to the G3X. Added new Baro Settings popup to the G3X Touch. Dec 31, 2020
@arron-h

arron-h commented Dec 31, 2020

Copy link
Copy Markdown
Author

Other noteworthy additions: I've added a title-small CSS class to gradientButton as the default titles I felt were way too big.

Here's an example screenshot of the Transponder input page from the G3X manual, which I based the button from:

transponder

I hope to refactor other popup dialogs to use the same class for consistency.

@arron-h

arron-h commented Dec 31, 2020

Copy link
Copy Markdown
Author

And here's a single frame of a YouTube video of the Baro Setting page on a G3X Touch. Note that because the aircraft is on the ground, 'Set For Field' is displayed. Once airbourne I believe this changes to 'Set Standard' as included in this PR.

baro setting

@arron-h
arron-h marked this pull request as draft December 31, 2020 23:16
@arron-h

arron-h commented Dec 31, 2020

Copy link
Copy Markdown
Author

Marking as draft as I'm doing a bit of rework to improve the clickspot handling, text alignment and code consistency.

This is activated by clicking on the baro reference value under the altimeter.
In order to bring this popup up, an ID was required to be added to the baro reference text and container rect in the shared Altimeter.js.
Input is validated against maximum and minimum pressure values of 32.01 and 27.99 respectively.
@arron-h
arron-h force-pushed the g3x_baro_settings_popup branch from a963b55 to 4ecedd1 Compare December 31, 2020 23:29
@arron-h
arron-h marked this pull request as ready for review December 31, 2020 23:40
@arron-h

arron-h commented Dec 31, 2020

Copy link
Copy Markdown
Author

OK, happy with this PR now. Attaching updates screenshot showing fixed centering of text.

kingair_baro_set_2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant