This repository was archived by the owner on May 16, 2024. It is now read-only.
Conversation
Author
|
Validation on the input is performed. As can be seen, the Enter button is greyed out. The Enter button activates when a valid pressure setting (ranging from 27.99 to 32.01) is input. Clicking Set Standard fills in 29.92 and activates the Enter button. |
Author
|
Other noteworthy additions: I've added a Here's an example screenshot of the Transponder input page from the G3X manual, which I based the button from: I hope to refactor other popup dialogs to use the same class for consistency. |
Author
arron-h
marked this pull request as draft
December 31, 2020 23:16
Author
|
Marking as draft as I'm doing a bit of rework to improve the clickspot handling, text alignment and code consistency. |
This is activated by clicking on the baro reference value under the altimeter. In order to bring this popup up, an ID was required to be added to the baro reference text and container rect in the shared Altimeter.js. Input is validated against maximum and minimum pressure values of 32.01 and 27.99 respectively.
arron-h
force-pushed
the
g3x_baro_settings_popup
branch
from
December 31, 2020 23:29
a963b55 to
4ecedd1
Compare
arron-h
marked this pull request as ready for review
December 31, 2020 23:40
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is activated by clicking on the baro reference value under the altimeter.
In order to bring this popup up, an ID was required to be added to the baro reference text in the shared Altimeter.js.