Repository navigation
chore: remove unused NetworkStrings TELEGRAMS_TITLE/TELEGRAMS_SELECTED - #156
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
==========================================
- Coverage 61.46% 61.46% -0.01%
==========================================
Files 156 156
Lines 11088 11082 -6
Branches 1490 1490
==========================================
- Hits 6815 6811 -4
+ Misses 4111 4109 -2
Partials 162 162
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused TELEGRAMS_TITLE and TELEGRAMS_SELECTED properties from NetworkStrings along with the now-orphaned German and Dutch translation entries (and recompiled .mo files). Both are superseded by inline code in network/ui.py: the Telegrams/CEMI radio button uses a hardcoded "Telegrams" literal (ui.py:159), and the toolbar selection counter uses an f"{selected_count}/{count}" format instead of the "({count} selected)" template (ui.py:145). No callers of either property exist anywhere in the codebase.
History
Dead Code PRs can be configured here.