Skip to content

chore: remove unused NetworkStrings TELEGRAMS_TITLE/TELEGRAMS_SELECTED - #156

Open
detail-app[bot] wants to merge 1 commit into
masterfrom
detail/dead-code/chore-remove-unused-networkstrings-telegrams-title-243ce6
Open

detail-app[bot] wants to merge 1 commit into
masterfrom
detail/dead-code/chore-remove-unused-networkstrings-telegrams-title-243ce6

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Remove the unused TELEGRAMS_TITLE and TELEGRAMS_SELECTED properties from NetworkStrings along with the now-orphaned German and Dutch translation entries (and recompiled .mo files). Both are superseded by inline code in network/ui.py: the Telegrams/CEMI radio button uses a hardcoded "Telegrams" literal (ui.py:159), and the toolbar selection counter uses an f"{selected_count}/{count}" format instead of the "({count} selected)" template (ui.py:145). No callers of either property exist anywhere in the codebase.

History

  • Last materially changed May 2026 (@kewde)

Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from kewde September 28, 2026 23:50
@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.46%. Comparing base (7f7ef57) to head (43cd033).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   61.46%   61.46%   -0.01%     
==========================================
  Files         156      156              
  Lines       11088    11082       -6     
  Branches     1490     1490              
==========================================
- Hits         6815     6811       -4     
+ Misses       4111     4109       -2     
  Partials      162      162              
Files with missing lines Coverage Δ
...pps/knx-gui/src/knx_gui/plugins/network/strings.py 80.00% <ø> (+3.80%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant