Support for execution costs per Hook APIs [DO NOT MERGE]#613
Open
tequdev wants to merge 65 commits into
Open
Conversation
…Hook.h into a single file.
…xecute guard-checker
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #613 +/- ##
=======================================
- Coverage 77.3% 77.3% -0.0%
=======================================
Files 837 839 +2
Lines 78575 78816 +241
Branches 11551 11580 +29
=======================================
+ Hits 60748 60923 +175
- Misses 17817 17883 +66
Partials 10 10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
require: #622
Allow custom costs to be set for each HookAPI, enabling more appropriate execution costs to be billed.
(Currently, calling HookAPI incurs no additional cost and has the same cost as general Wasm instructions (1 drop))
HookDefinitionUpdatetransaction added, allowing guard-checkers to be run on already deployed HookDefinitions.Change the Hook execution fee format from sfFee/sfHookCallbackFee (STAmount) to sfHookCost/sfHookCallbackCost (uint64), allowing a more flexible and precise drop-based cost model instead of the previous fixed 1-drop-per-instruction structure.
Type of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)