Skip to content

fix: 이메일 회원가입 성공시 토큰 응답 및 이메일 분기 응답 수정 - #234

Merged
SinnoLn merged 1 commit into
devfrom
fix/email-auth-process
Aug 21, 2026
Merged

fix: 이메일 회원가입 성공시 토큰 응답 및 이메일 분기 응답 수정#234
SinnoLn merged 1 commit into
devfrom
fix/email-auth-process

Conversation

@SinnoLn

@SinnoLn SinnoLn commented Aug 21, 2026

Copy link
Copy Markdown
Member

📝 작업 내용

  • 로컬 회원가입 완료후 토큰 발급
  • 이메일 분기 응답시 휴먼 여부 상관없이 조회되도록 변경

✅ 체크리스트

  • 로컬에서 빌드 및 테스트가 통과했습니다.
  • 컨벤션(브랜치/커밋 메시지)을 준수했습니다.
  • 관련 문서를 수정했습니다. (필요한 경우)

@SinnoLn SinnoLn self-assigned this Aug 21, 2026
@SinnoLn SinnoLn added the bug Something isn't working label Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@SinnoLn, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5a19d6d5-613d-4d1c-b05f-7581e110d94b

📥 Commits

Reviewing files that changed from the base of the PR and between 44ee768 and 11778cc.

📒 Files selected for processing (7)
  • src/main/java/chaeso/zip/server/auth/application/AuthService.java
  • src/main/java/chaeso/zip/server/auth/application/AuthServiceImpl.java
  • src/main/java/chaeso/zip/server/auth/application/dto/UserResponse.java
  • src/main/java/chaeso/zip/server/auth/presentation/AuthApiDocs.java
  • src/main/java/chaeso/zip/server/auth/presentation/AuthController.java
  • src/test/java/chaeso/zip/server/auth/application/AuthServiceTest.java
  • src/test/java/chaeso/zip/server/auth/presentation/AuthControllerTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.92%. Comparing base (44ee768) to head (11778cc).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev     #234   +/-   ##
=========================================
  Coverage     91.92%   91.92%           
  Complexity      790      790           
=========================================
  Files           131      131           
  Lines          2377     2377           
  Branches        204      204           
=========================================
  Hits           2185     2185           
  Misses          129      129           
  Partials         63       63           
Files with missing lines Coverage Δ
...o/zip/server/auth/application/AuthServiceImpl.java 96.36% <100.00%> (ø)
...o/zip/server/auth/presentation/AuthController.java 85.71% <ø> (ø)
Components Coverage Δ
auth 95.66% <100.00%> (ø)
channel 82.53% <ø> (ø)
onboarding 89.00% <ø> (ø)
estimation 94.11% <ø> (ø)
performance 91.66% <ø> (ø)
simulation 91.82% <ø> (ø)
user 96.96% <ø> (ø)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@claude

claude Bot commented Aug 21, 2026

Copy link
Copy Markdown

PR 리뷰 결과

머지를 막을 필요가 있는(must-fix) 문제를 찾지 못했습니다.

확인한 내용

  • signup()UserResponse → TokenResponse 변경: 컨트롤러/테스트/OpenAPI 문서 예시가 모두 일관되게 갱신됨. UserResponse 참조가 코드 전체에 남아있지 않음을 확인.
  • findLoginMethods()findByEmailAndDeletedAtIsNull → findByEmail 변경: LoginMethodsResponsedeletedAt 등 탈퇴 상태를 노출하지 않고 provider 목록만 반환하므로 정보 노출 문제 없음. 탈퇴 계정에 대한 실제 로그인/가입 시도는 기존 rejectWithdrawn/restoreIfPossible 로직이 그대로 막고 있어 일관성 유지됨.
  • ArchUnit 계층 규칙(presentation→application DTO만 사용) 위반 없음.
  • 관련 단위/컨트롤러 테스트가 변경된 동작(토큰 발급, 탈퇴 계정도 로그인 수단 조회됨)을 커버함.

Nit 수준(오탈자 등)은 게이트 특성상 생략합니다.

@SinnoLn
SinnoLn merged commit a25f584 into dev Aug 21, 2026
3 checks passed
@SinnoLn
SinnoLn deleted the fix/email-auth-process branch August 21, 2026 15:35
SinnoLn added a commit that referenced this pull request Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants