Skip to content

fix: 기간당 과금(CPP) 매체의 노출/클릭 추정 누락 수정 - #236

Merged
1117mg merged 1 commit into
devfrom
fix/estimation-cpp-impressions
Aug 22, 2026
Merged

fix: 기간당 과금(CPP) 매체의 노출/클릭 추정 누락 수정#236
1117mg merged 1 commit into
devfrom
fix/estimation-cpp-impressions

Conversation

@1117mg

@1117mg 1117mg commented Aug 22, 2026

Copy link
Copy Markdown
Member

📝 작업 내용

  • 단위형 과금 모델 집합에 CPP 추가
  • CPP 케이스 단위 테스트 추가

✅ 체크리스트

  • 로컬에서 빌드 및 테스트가 통과했습니다.
  • 컨벤션(브랜치/커밋 메시지)을 준수했습니다.
  • 관련 문서를 수정했습니다. (필요한 경우)

@1117mg 1117mg self-assigned this Aug 22, 2026
@1117mg 1117mg added the bug Something isn't working label Aug 22, 2026
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: eae1063f-6e39-4eff-ad8b-b8ff80ceec51


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@claude

claude Bot commented Aug 22, 2026

Copy link
Copy Markdown

🤖 자동 리뷰 결과

머지 전 반드시 수정해야 할 문제를 찾지 못했습니다.

검토 내용: UNIT_BASED_MODELSCPP 추가가 hasImpressionBasis/impressionBounds 로직과 일관되게 동작하는지 확인했고, 추가된 테스트(EstimationServiceTest, SimulationServiceImplTest)의 기대값(노출·클릭 범위, CPC)을 직접 재계산해 검증했습니다 — 모두 일치합니다. PricingModel.CPP는 이미 존재하던 enum 값이라 Flyway 마이그레이션도 불필요합니다. ArchUnit 계층 규칙 위반이나 보안 이슈도 없습니다.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.92%. Comparing base (43c0593) to head (69c78ca).
⚠️ Report is 4 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #236      +/-   ##
============================================
- Coverage     92.02%   91.92%   -0.10%     
- Complexity      789      790       +1     
============================================
  Files           130      131       +1     
  Lines          2369     2377       +8     
  Branches        208      204       -4     
============================================
+ Hits           2180     2185       +5     
- Misses          125      129       +4     
+ Partials         64       63       -1     
Files with missing lines Coverage Δ
...ip/server/estimation/domain/EstimationService.java 92.15% <100.00%> (ø)

... and 8 files with indirect coverage changes

Components Coverage Δ
auth 95.66% <ø> (-0.82%) ⬇️
channel 82.53% <ø> (ø)
onboarding 89.00% <ø> (ø)
estimation 94.11% <100.00%> (ø)
performance 91.66% <ø> (ø)
simulation 91.82% <ø> (ø)
user 96.96% <ø> (+0.24%) ⬆️

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1117mg
1117mg merged commit 68923b9 into dev Aug 22, 2026
3 checks passed
@1117mg
1117mg deleted the fix/estimation-cpp-impressions branch August 22, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants